Repository navigation
Favicon for Safari: favicon.ico, and ?v=2 on the icon links - #46
Merged
Merged
Conversation
Safari before 26 shows no SVG favicon (on the Mac its grey letter placeholder), so the site gets favicon.ico (16, 32, 48 px, from favicon.svg) as the first icon link, the SVG for the others. All three icon links carry ?v=2, a new address, so browsers fetch them afresh instead of a cached older icon. test:browser checks the links and that the icons load through the service worker with their query. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P41 follow-up: Safari shows the bike as favicon too.
What changes
public/favicon.ico: your file, unchanged (16, 32 and 48 px, rendered fromfavicon.svg).index.html:.ico: Safari supports SVG favicons only from Safari 26. Safari 18.6 on the Mac found no icon it could use, hence its grey «G».?v=2: it gives each icon a new address, so a browser fetches it afresh. A comment inindex.htmlsays to raise it when the logo changes.The query survives the build and the service worker
dist/index.htmlas written (files frompublic/aren't renamed), and copiesfavicon.icounchanged.coi-serviceworker.jsonly passes requests through to add the isolation headers. It has no Cache API and doesn't rewrite URLs.favicon.svgandapple-touch-icon.pngwithCache-Control: max-age=600, so the server never hands out an old icon for more than 10 minutes. Todayfavicon.svgis already the bike, andfavicon.icogives a 404 until this PR.Checks
test:browser(27 checks, 1 new): the page has exactly these three links, and all three icons load through the page, and so through the service worker, with?v=2: status 200, an image type, not empty.Going live
Merging deploys the IDE. Nothing else is needed.
Manual tests (without deleting website data)
Follow-ups (not done)
🤖 Generated with Claude Code